Fix initial value for volume in zynthian YML files. - #12
Conversation
…on (keyswitched). + Increasestereo volume to match mono version.
jlearman
left a comment
jlearman
left a comment
There was a problem hiding this comment.
Thanks for your work on this! Just a few nits.
I'll probably be deleting the stereo vibrato samples in the future.
There was a problem hiding this comment.
This image is inauthentic. A Mk I top isn't flat, it's curved, and the Rhodes logo in front doesn't say "Fender." Also, the case isn't quite right. Looks AI. (Pianos that preceded the Mk I did have the "Fender" logo. And older ones than that didn't ... it's a long and sordid tale.)
Didn't you like my pic of the actual piano that was sampled? Yeah, it's not a great image, but it's the actual piano! The sticky tabs on the keyboard are the sampled notes. ;-)
But I can't find a specifically free image. The wikipedia page has a good pic of an 88.
| // 1. Setup the LFO | ||
| lfo02_wave=0 // Smooth Sine wave (best for seamless left-to-right gliding) | ||
| // 2. Map CC95 to Auto-Pan Depth | ||
| lfo02_wave=0 // Waveform shape (0 = Sine, 1 = Triangle, 2 = Sawtooth) |
There was a problem hiding this comment.
2 isn't sawtooth, it's 75% duty cycle.
Please add:
lfo02_phase=0.35 // start just right of center and pan to left
| label_cc94=AutoPan Depth | ||
| label_cc95=AutoPan Freq | ||
| set_hdcc94=0 | ||
| set_hdcc95=0.5 |
There was a problem hiding this comment.
Please change the default:
set_hdcc95=0.12
(This was adjusted from what I tested on Zynthian based on your changes here. It's about 1/2 Hz.)
| width_curvecc1=99 | ||
|
|
||
| // Implement tremolo (amplitude modulation) with mod-wheel | ||
| lfo01_wave=0 // Waveform shape (0 = Sine, 1 = Triangle, 2 = Sawtooth) |
There was a problem hiding this comment.
2 is not sawtooth, it's 75% duty cycle. Here and below.
| lfo01_freq_oncc92=9.9 // Knob adds up to 9.9 Hz to the speed (Total 10.0 Hz max) | ||
|
|
||
| // Implement Auto-Pan | ||
| lfo02_wave=0 // Waveform shape (0 = Sine, 1 = Triangle, 2 = Sawtooth) |
There was a problem hiding this comment.
Pl;ease add
lfo02_phase=0.4
This starts the sound from just right of center, moving toward center, and provides a better balance than starting center and moving right.
| label_cc94=AutoPan Depth | ||
| label_cc95=AutoPan Freq | ||
| set_hdcc94=0 | ||
| set_hdcc95=0.5 |
There was a problem hiding this comment.
Please adjust initial value for auto-pan speed around 2 Hz. I did the math in the review comment earlier, but I don't know how to find that now. EDIT: OOPS! I meant 1/2 Hz. One cycle over about 2 seconds.
This is the value I used for the first package, but I believe you changed the endpoints so it might not be correct.
set_hdcc95=0.06
| width_curvecc1=99 | ||
|
|
||
| // Implement tremolo (amplitude modulation) with mod-wheel | ||
| lfo01_wave=0 // Waveform shape (0 = Sine, 1 = Triangle, 2 = Sawtooth) |
There was a problem hiding this comment.
| lfo01_wave=0 // Waveform shape (0 = Sine, 1 = Triangle, 2 = Sawtooth) | |
| lfo01_wave=0 // Waveform shape (0 = Sine, 1 = Triangle) |
2 participants
No description provided.